Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Merged okta tck fixes #332

Merged
merged 7 commits into from
Apr 28, 2017
Merged

Merged okta tck fixes #332

merged 7 commits into from
Apr 28, 2017

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Apr 25, 2017

Fixes #330 and #331

@bdemers bdemers requested a review from nbarbettini April 25, 2017 20:19
@bdemers
Copy link
Contributor Author

bdemers commented Apr 25, 2017

@nbarbettini I'm less sure of the changes in de8ded7 but they didn't cause a problem on my end. I'm not sure if we should set the content type to JSON as i'm not sure if that was an assumption that the previous versions of the Stormpath SDKs or not.
But I'll leave that one up to you.

@nbarbettini
Copy link
Member

@bdemers That content-type is in the framework spec; I'm not sure why we weren't sending it explicitly in the TCK before (probably an oversight). The other changes in de8ded7 are minor fixes for smoothing over timeouts and loosening some string matching.

👍

@bdemers bdemers merged commit 8545bbe into master Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbarbettini nbarbettini nbarbettini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdemers @nbarbettini